Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize to Resolution on Apple MacBook Retina Display too big? #39

Open
chrisspiegl opened this issue Nov 21, 2020 · 5 comments
Open

Resize to Resolution on Apple MacBook Retina Display too big? #39

chrisspiegl opened this issue Nov 21, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@chrisspiegl
Copy link

As mentioned in the other issue I opened, I am new to the Electron Capture and OBS.Ninja 🙈.
I read that the window has the Right Click + Resize Window options and that's an awesome idea.
However, I also noticed that the resize seems to not quite do the same on my internal MacBook Retina display.
I right click => resize window => select 720p and then it resizes to be rather large.
Once captured inside OBS and selecting the options "Edit Transform" it shows the following:

Screen Shot 2020-11-21 at 23 28 13

So… basically; it seems that it has not resized the window with retina kept in mind and instead the window ended up about twice the size that it should be?

Am I misunderstanding something? Would it maybe be possible to be able to enter a custom window size in the Right Click Resize Window menu? Or possibly fix the window resize to take into account the retina display characteristics?

I am not sure what the right way would be here (or if I just have to change what I am doing).

I am looking forward to hearing from you,
Chris

P.S.: I am on a MacBook Pro 15" 2017 model with macOS Big Sur installed.

@steveseguin
Copy link
Owner

I'll look into this. Thank you for reporting. I don't have access to Big Sur yet and things do keep changing from update to update, so it's hard to say currently. I also don't have access to a retina display at the moment either; just a mac mini.

The code however SHOULD take into consider Retina displays, as I coded it to do that, and so it should automatically make the WIndow half the size (to compensate for the pixel density). It looks like in this case it didn't work right -- it didn't detect that it was on a retina display I guess. I'll need to look into this and get back to you after I do some reading and testing.

Thank you for the bug report

@steveseguin
Copy link
Owner

So I think I got a partial fix in for this; will post a test build when I get time to compile it.

@steveseguin steveseguin added the bug Something isn't working label Nov 23, 2020
@steveseguin
Copy link
Owner

I'm unable to test this myself, at least at present. I think I need to buy a new Macbook, something with a retina display and ARM chip, so I can test and develop going forward.
https://github.com/steveseguin/electroncapture/releases/tag/1.2.0

side vent: Supporting Apple products is a real pain in the ass.

@chrisspiegl
Copy link
Author

Hi Steve,
I just did that test 👍 and here are my results:

Downloaded and tested with:

  • Primary Display (non Retina)
  • Intel MacBook Retina Display as Secondary

Reacts as described in the release notes:

  • opens on primary (non-retina) in the correct size for 1280x720
  • resize to 1920x1080 works correctly
  • move to secondary (retina display)
  • size stays the same (as expected)
  • resize to 1920x1080 (or any other) results in the correct size with retina taken into account so a 1x1 pixel representation for window and display capture

Thank you for the quick work and release of this.

P.S. I understand the vent (when not using Apple as the default, because if done… the reverse is also true — speaking from experience 🙈.

@steveseguin
Copy link
Owner

steveseguin commented Nov 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants