Switch from define() to the const keyword #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rolling out version 2.0.1 last night and updating the version at the day job, @ChadSikorra and @ramsey pointed out that
constnot only plays nicer with IDEs but also has some slight performance improvements (constis defined at compile time, whiledefine()happens at runtime). This is backed up by this StackOverflow answer from @nikic, so I'd say this is a good improvement for this library 😄This PR replaces the
define(__NAMESPACE__ . '\\CONSTANT_NAME')syntax withconst CONSTANT_NAMEfor easy, micro-optimized wins all around!