Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: highlight treesitter off if the quickfix list is long. #12

Closed
1 task done
sergiornelas opened this issue Aug 10, 2024 · 3 comments
Closed
1 task done
Labels
enhancement New feature or request question Further information is requested

Comments

@sergiornelas
Copy link

Did you check existing requests?

  • I have searched the existing issues

Describe the feature

Hello. I love your plugin btw. But if I get the LSP references and the list is quite big (+100 references), the quickfix renders slower. Maybe we could add an option that disables the treesitter highlight if the list is 50+ elements.
:-)

Provide background

No response

What is the significance of this feature?

nice to have

Additional details

No response

@sergiornelas sergiornelas added the enhancement New feature or request label Aug 10, 2024
@stevearc
Copy link
Owner

Could you be a bit more specific about the problem you are seeing? Does the quickfix buffer take longer to open? Is it causing Neovim to be laggy? Is it just taking a while to highlight?

I made the highlighting (both treesitter and LSP) async with the intention that highlighting might take longer for long lists, but it shouldn't block the UI and ideally won't add much lag (some lag is unavoidable).

@stevearc stevearc added the question Further information is requested label Aug 13, 2024
@uwla
Copy link

uwla commented Aug 16, 2024

I am also experiencing this issue.

UPDATE: the buggy behavior I was experiencing has disappeared. Here is what happend: open a project, change to a subdirectory, make some search and put the files into a quickfix list. Initally, the quickfix list has the correct file paths and the highlight works. If I close the session and reopens again, the file paths of the quickfix list are not correct: they were relative to that subdirectory but now they are relative to the project directory, thus are inexisting files. This is what caused the bug... But this depends on how the session is saved (I have to figure it out, it is handled by other plugin)

@github-actions github-actions bot removed the question Further information is requested label Aug 16, 2024
@stevearc stevearc added the question Further information is requested label Aug 18, 2024
@stevearc
Copy link
Owner

closing for lack of response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants