Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: expand()/ collapse() should also resize window #10

Closed
1 task done
chrisgrieser opened this issue Aug 8, 2024 · 1 comment
Closed
1 task done
Labels
enhancement New feature or request

Comments

@chrisgrieser
Copy link

Did you check existing requests?

  • I have searched the existing issues

Describe the feature

when using expand() or collapse(), also adjust the window size.

Provide background

Right now, using expand() does not affect window size. That means, if I have for example 5 items in my qflist, after expanding, the window is still 5 lines high, which is somewhat too small to properly work with.

What is the significance of this feature?

nice to have

Additional details

No response

@chrisgrieser chrisgrieser added the enhancement New feature or request label Aug 8, 2024
@stevearc
Copy link
Owner

stevearc commented Aug 8, 2024

I agree with the sizing, but this is such a simple thing to do with your own bindings that I don't think it's worth complicating the API that quicker provides. This is what I do in my own config:

function()
  require("quicker").expand({ before = 2, after = 2, add_to_existing = true })
  vim.api.nvim_win_set_height(0, math.min(20, vim.api.nvim_buf_line_count(0)))
end

@stevearc stevearc closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants