Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in Keenerd's improvements? #29

Open
labeneator opened this issue Mar 7, 2016 · 3 comments
Open

Pull in Keenerd's improvements? #29

labeneator opened this issue Mar 7, 2016 · 3 comments

Comments

@labeneator
Copy link

Hi,
There are a couple of improvements by @keenerd documented here: https://www.reddit.com/r/RTLSDR/comments/2cix12/improvements_to_hopping_and_filters_testing/ and used in other projects that depend on librtlsdr. Since this repo is used for OSX homebrew, those changes are not available to homebrew users. This breaks other projects that depend on these changes; Kalibrate-rtl as an example:

 ~/d/b/kalibrate-rtl  ❯ make clean all
Making clean in src
test -z "kal" || rm -f kal
rm -f *.o
make[1]: Nothing to be done for `clean-am'.
/Library/Developer/CommandLineTools/usr/bin/make  all-recursive
Making all in src
g++ -DHAVE_CONFIG_H -I. -I..    -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/librtlsdr/0.5.3/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2 -MT kal-arfcn_freq.o -MD -MP -MF .deps/kal-arfcn_freq.Tpo -c -o kal-arfcn_freq.o `test -f 'arfcn_freq.cc' || echo './'`arfcn_freq.cc
......
.....
g++ -DHAVE_CONFIG_H -I. -I..    -I/usr/local/Cellar/fftw/3.3.4_1/include -I/usr/local/Cellar/librtlsdr/0.5.3/include/ -I/usr/local/Cellar/libusb/1.0.20/include/libusb-1.0 -g -O2 -MT kal-usrp_source.o -MD -MP -MF .deps/kal-usrp_source.Tpo -c -o kal-usrp_source.o `test -f 'usrp_source.cc' || echo './'`usrp_source.cc
usrp_source.cc:153:17: error: use of undeclared identifier 'rtlsdr_set_dithering'
        return (bool)(!rtlsdr_set_dithering(dev, (int)enable));
                       ^
1 error generated.
make[2]: *** [kal-usrp_source.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Please pull in the changes and create a release tag.

Thanks

@Romeo-Golf
Copy link

+1

@E3V3A
Copy link

E3V3A commented Mar 13, 2017

@steve-m Did you abandon this project?

@cfstras
Copy link

cfstras commented Mar 15, 2017

There's a more active fork at https://github.com/librtlsdr/librtlsdr .
This repo has last been updated 4 months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants