From f0853b06b4a1002bd1f561da03c4e26ca606fce9 Mon Sep 17 00:00:00 2001 From: Justin Frydman Date: Thu, 6 Jun 2024 13:40:05 -0600 Subject: [PATCH 1/2] Fix types for where values --- src/DB/QueryBuilder/Clauses/Where.php | 2 +- src/DB/QueryBuilder/Concerns/WhereClause.php | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/DB/QueryBuilder/Clauses/Where.php b/src/DB/QueryBuilder/Clauses/Where.php index 11b719a..5db6549 100644 --- a/src/DB/QueryBuilder/Clauses/Where.php +++ b/src/DB/QueryBuilder/Clauses/Where.php @@ -36,7 +36,7 @@ class Where { /** * @param string $column - * @param string $value + * @param mixed $value * @param string $comparisonOperator * @param string|null $logicalOperator */ diff --git a/src/DB/QueryBuilder/Concerns/WhereClause.php b/src/DB/QueryBuilder/Concerns/WhereClause.php index e62ed8f..d90b0c5 100644 --- a/src/DB/QueryBuilder/Concerns/WhereClause.php +++ b/src/DB/QueryBuilder/Concerns/WhereClause.php @@ -29,7 +29,7 @@ trait WhereClause { /** * @param string|Closure|null $column The Closure will receive a StellarWP\DB\QueryBuilder\WhereQueryBuilder instance - * @param string|Closure|array|null $value The Closure will receive a StellarWP\DB\QueryBuilder\QueryBuilder instance + * @param string|Closure|array|null|mixed $value The Closure will receive a StellarWP\DB\QueryBuilder\QueryBuilder instance * @param string $comparisonOperator * @param string $logicalOperator * @@ -79,7 +79,7 @@ private function setWhere( $column, $value, $comparisonOperator, $logicalOperato /** * @param string|Closure|null $column The closure will receive a StellarWP\DB\QueryBuilder\WhereQueryBuilder instance - * @param string|Closure|array|null $value The closure will receive a StellarWP\DB\QueryBuilder\QueryBuilder instance + * @param string|Closure|array|null|mixed $value The closure will receive a StellarWP\DB\QueryBuilder\QueryBuilder instance * @param string $comparisonOperator * * @return $this @@ -95,7 +95,7 @@ public function where( $column, $value = null, $comparisonOperator = '=' ) { /** * @param string|Closure $column - * @param string|Closure|array|null $value + * @param string|Closure|array|null|mixed $value * @param string $comparisonOperator * * @return $this @@ -255,7 +255,7 @@ public function whereNotLike( $column, $value ) { /** * @param string $column - * @param string $value + * @param mixed $value * * @return $this */ @@ -269,7 +269,7 @@ public function orWhereLike( $column, $value ) { /** * @param string $column - * @param string $value + * @param mixed $value * * @return $this */ From b2554100e4e9e9f37617691a0e668c9d9a2aba5c Mon Sep 17 00:00:00 2001 From: Justin Frydman Date: Thu, 6 Jun 2024 13:40:22 -0600 Subject: [PATCH 2/2] Remove unused variable --- src/DB/QueryBuilder/Clauses/Where.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/DB/QueryBuilder/Clauses/Where.php b/src/DB/QueryBuilder/Clauses/Where.php index 5db6549..815ef06 100644 --- a/src/DB/QueryBuilder/Clauses/Where.php +++ b/src/DB/QueryBuilder/Clauses/Where.php @@ -9,6 +9,7 @@ * @since 1.0.0 */ class Where { + /** * @var string */ @@ -29,11 +30,6 @@ class Where { */ public $logicalOperator; - /** - * @var string|null - */ - public $type; - /** * @param string $column * @param mixed $value