-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename install
to upload
; alias as install
#1621
Comments
💯 The big reason to do this rename is that "upload" is what the protocol ended up calling it, and the cli never caught up and updated to the same vocab. |
I would like to work on this I will approach this task of renaming install to upload while preserving backwards compatibility by following these steps: Rename the Command: I will modify the existing codebase to rename the command install to upload wherever it appears in the XDR & SDK, ensuring the terminology is consistent with the notion of uploading to the blockchain. To maintain backwards compatibility, I will create an alias for the old install command that maps to upload. This way, any existing scripts or documentation referring to install will continue to function without issues. I will update the relevant documentation to reflect the change from install to upload. The documentation will note that install is now an alias for upload to avoid confusion for new users. After making these changes, I will test both the upload command and the install alias to ensure that both function correctly and produce the same results. ETA - 3 days |
Hey @PoulavBhowmick03! |
In the XDR & SDK, the operation is called
upload
."Upload" makes more sense with most people's mental model, too. From the perspective of the person issuing the command, they are uploading something to the blockchain. Only from the perspective of the blockchain itself does it make sense to think of it as an "upload."
Let's rename the command. To avoid breaking the numerous scripts and docs that refer to the old name, let's alias it with the old
install
name. We can keep the alias around indefinitely.The text was updated successfully, but these errors were encountered: