Tighten signature of unchecked_visit_val_obj, fix #595 #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three things:
unchecked_visit_val_obj
(it's currently done in all callers).unsafe
qualifier, there's really nothing about it that a caller has to think carefully about (and arguably we're misusingunsafe
for this purpose all through the codebase, I expect nobody appreciates this instance!)visit_obj_untyped
This (plus earlier work tightening up its args) addresses anything I had in mind for #595