Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten signature of unchecked_visit_val_obj, fix #595 #997

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Aug 15, 2023

This does three things:

  • Sinks the check for unknown object handles into unchecked_visit_val_obj (it's currently done in all callers).
  • Removes the unsafe qualifier, there's really nothing about it that a caller has to think carefully about (and arguably we're misusing unsafe for this purpose all through the codebase, I expect nobody appreciates this instance!)
  • Renames the function to be a little less hazardous-sounding: visit_obj_untyped

This (plus earlier work tightening up its args) addresses anything I had in mind for #595

@graydon graydon requested a review from sisuresh as a code owner August 15, 2023 22:52
@graydon graydon enabled auto-merge (squash) August 15, 2023 22:53
@graydon graydon merged commit 7c5f60a into main Aug 15, 2023
8 checks passed
@graydon graydon deleted the bug-595-tighten-unchecked_visit_val_obj branch August 15, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants