Charge write fees for read-only rent entry bumps. #996
Conversation
Write entry bumps are already charged separately as a part of the total write fees.
FWIW this is supposed to only be called on sanitized small inputs (everything is controlled by the protocol-imposed limits), so I wanted to save some typing/cycles on this. But I guess it's not really significant, so might as well just have safer ops everywhere. |
| @@ -258,20 +288,20 @@ fn rent_fee_per_entry_change( | |||
| entry_change.new_expiration_ledger | |||
| - entry_change.old_expiration_ledger.max(current_ledger - 1), | |||
There was a problem hiding this comment.
I think this can underflow if current_ledger > new_expiration_ledger > old_expiration_ledger
There was a problem hiding this comment.
(I'm not sure if a saturating sub is better here or hoisting the max up to the if condition that guards this block
There was a problem hiding this comment.
current_ledger > new_expiration_ledger > old_expiration_ledger should never happen - again, this is not a library to use for arbitrary inputs, but a helper to use with well-behaved state managed by core or preflight. These shouldn't ever pass the expired entries to the host.
Co-authored-by: Graydon Hoare <[email protected]>
Co-authored-by: Graydon Hoare <[email protected]>
|
Given that we might be changing how the rent works, I'll close this for the time being as it probably will become irrelevant. |
What
Charge write fees for read-only rent entry bumps.
Write entry bumps are already charged separately as a part of the total write fees.
Why
RO entry bumps need to be written in ledger, so there is always some 'flat' fee component due to the write (so bumping the entry by 1 ledger is not just 1 stroop).
Known limitations
N/A