[ANCHOR- 474] Update SEP10.home_domain to accommodate multi-tenancy #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiahuiWho
commented
Oct 19, 2023
lijamie98
reviewed
Oct 23, 2023
platform/src/main/java/org/stellar/anchor/platform/config/PropertySep10Config.java
Show resolved
Hide resolved
platform/src/main/resources/config/anchor-config-default-values.yaml
Outdated
Show resolved
Hide resolved
platform/src/main/resources/config/anchor-config-default-values.yaml
Outdated
Show resolved
Hide resolved
platform/src/main/resources/config/anchor-config-default-values.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jamie Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
home_domainsto SEP-10 to take a list of domains,Rename
Sep10Config::getHomeDomain()toSep10Config::getHomeDomains()to always return a list of available domainshome_domainandhome_domainscannot coexist in Sep10Config, this is comment in default-value.yml, also enforced in validation rulesweb_auth_domainwill be required if there are more than 1 home domain specified inhome_domainsContext
The SDP multi-tenant integration will rely on multiple toml files, so we’ll need the Anchor Platform to accommodate that by allowing multiple home_domains to be configured, in the format of a comma-separated list of domains.
Testing
./gradlew test