Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp/services/webauth: send application name to Horizon #2752

Closed
leighmcculloch opened this issue Jun 26, 2020 · 3 comments
Closed

exp/services/webauth: send application name to Horizon #2752

leighmcculloch opened this issue Jun 26, 2020 · 3 comments

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Jun 26, 2020 •
edited
Loading

What

Send application name, but not version, in requests to Horizon using the Go SDKs config AppName field.

Why

So that when running the webauth service alongside Horizon with other services that interact with Horizon, it is possible to distuingish in logs which requests have come from the webauth service and therefore possible to generate metrics on the usage of the Horizon API by the webauth service.
@ire-and-curses
Copy link
Member

Could you expand on the "Why" a little? I'm having trouble grasping what this does.

@leighmcculloch
Copy link
Member Author

Could you expand on the "Why" a little? I'm having trouble grasping what this does.

Expanded. Let me know if that makes more sense.

@mollykarcher
Copy link
Contributor

Closing all webauth issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leighmcculloch @ire-and-curses @mollykarcher