-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump java-stellar-sdk to v1.0.0 #1575
Conversation
Wait for the wallet SDK update before continuing this PR. stellar/kotlin-wallet-sdk#155 |
platform/src/main/java/org/stellar/anchor/platform/observer/stellar/StellarPaymentObserver.java
Show resolved
Hide resolved
Thanks for submitting this PR. |
…o-v1 # Conflicts: # core/src/test/kotlin/org/stellar/anchor/sep10/Sep10ServiceTest.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@overcat Is the PR still in progress? |
Hi @lijamie98, we need to wait for the wallet-sdk to release a new version. Maybe you can coordinate that? |
I will. I am also working on the wallet-sdk which is pending our ops to add GH secrets to automate the release process. ETA next week. |
Hi @lijamie98, the code encountered a problem while running CI, but after I reran CI, there was no issue. If possible, could you help me take a look? I'm not very familiar with this area. |
Some of the tests in |
Description
Bump java-stellar-sdk to v1.0.0
Context
Due to the upcoming 1.0.0 containing many breaking changes, I created this PR to make the process a bit easier.
Testing
./gradlew test
Documentation
https://github.com/lightsail-network/java-stellar-sdk/blob/master/CHANGELOG.md
Known limitations
N/A