Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump java-stellar-sdk to v1.0.0 #1575

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Nov 11, 2024

Description

Bump java-stellar-sdk to v1.0.0

Context

Due to the upcoming 1.0.0 containing many breaking changes, I created this PR to make the process a bit easier.

Testing

  • ./gradlew test

Documentation

https://github.com/lightsail-network/java-stellar-sdk/blob/master/CHANGELOG.md

Known limitations

N/A

@overcat
Copy link
Contributor Author

overcat commented Nov 12, 2024

Wait for the wallet SDK update before continuing this PR. stellar/kotlin-wallet-sdk#155

@overcat overcat changed the title [Draft] Bump java-stellar-sdk to v1.0.0 Bump java-stellar-sdk to v1.0.0 Nov 13, 2024
@lijamie98
Copy link
Collaborator

Thanks for submitting this PR.

…o-v1

# Conflicts:
#	core/src/test/kotlin/org/stellar/anchor/sep10/Sep10ServiceTest.kt
Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lijamie98
Copy link
Collaborator

@overcat Is the PR still in progress?

@overcat
Copy link
Contributor Author

overcat commented Dec 6, 2024

Hi @lijamie98, we need to wait for the wallet-sdk to release a new version. Maybe you can coordinate that?

@lijamie98
Copy link
Collaborator

Hi @lijamie98, we need to wait for the wallet-sdk to release a new version. Maybe you can coordinate that?

I will. I am also working on the wallet-sdk which is pending our ops to add GH secrets to automate the release process. ETA next week.

@overcat overcat marked this pull request as ready for review December 18, 2024 07:41
@overcat
Copy link
Contributor Author

overcat commented Dec 18, 2024

Hi @lijamie98, the code encountered a problem while running CI, but after I reran CI, there was no issue. If possible, could you help me take a look? I'm not very familiar with this area.
https://github.com/stellar/anchor-platform/actions/runs/12385701275/job/34572520338?pr=1575#step:11:695

@lijamie98
Copy link
Collaborator

Hi @lijamie98, the code encountered a problem while running CI, but after I reran CI, there was no issue. If possible, could you help me take a look? I'm not very familiar with this area.
https://github.com/stellar/anchor-platform/actions/runs/12385701275/job/34572520338?pr=1575#step:11:695

Some of the tests in essential-tests can sometimes fail. The root cause seems like the message queue delivery being not stable. The problem usually goes away after re-run. We have a ticket in the backlog for fixing the essential tests instability.

@lijamie98 lijamie98 merged commit da5385a into stellar:develop Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants