You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The write() methods of BcolzDailyBarWriter and BcolzMinuteBarWriter have identical signatures but very different semantics. Specifically BcolzMinuteBarWriter.write()appends to the table, whereas BcolzDailyBarWriter.write()overwrites the table. This is currently undocumented.
Ideally the code would be refactored so that each class implements an abstract method in a common abstract base-class and the append/rewrite behavior is consistent across both, but obviously there might be backward-compatibility issues.
Failing that, it would be good to document whether the behavior appends or rewrites the table in the docstring for each method.
The text was updated successfully, but these errors were encountered:
phelps-sg
added a commit
to phelps-sg/zipline-reloaded
that referenced
this issue
Oct 9, 2023
The
write()
methods ofBcolzDailyBarWriter
andBcolzMinuteBarWriter
have identical signatures but very different semantics. SpecificallyBcolzMinuteBarWriter.write()
appends to the table, whereasBcolzDailyBarWriter.write()
overwrites the table. This is currently undocumented.Ideally the code would be refactored so that each class implements an abstract method in a common abstract base-class and the append/rewrite behavior is consistent across both, but obviously there might be backward-compatibility issues.
Failing that, it would be good to document whether the behavior appends or rewrites the table in the docstring for each method.
The text was updated successfully, but these errors were encountered: