Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market on Open #132

Open
AndreasClenow opened this issue Sep 15, 2022 · 1 comment
Open

Market on Open #132

AndreasClenow opened this issue Sep 15, 2022 · 1 comment

Comments

@AndreasClenow
Copy link

AndreasClenow commented Sep 15, 2022

Just a friendly suggestion:

For some EOD models, it makes sense to place orders as 'market on open', rather than the default Zipline logic of 'market on close'. It's quite simple really and I've modded my own setup for this, and I thought might be of interest to the community.

The 'market on close' logic is currently hard coded in the slippage.py file, and I suppose the reason for that is that Quantopian assumed intraday, minute data.

The simple solution would be to add a field input argument to the constructors in the slippage.py file. Quick, easy and gets the job done.

@stefan-jansen
Copy link
Owner

Good idea @AndreasClenow; will take it on the list for this year's attempts at improving the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants