Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 #237

Open
Nefcanto opened this issue Dec 8, 2024 · 1 comment
Open

React 19 #237

Nefcanto opened this issue Dec 8, 2024 · 1 comment

Comments

@Nefcanto
Copy link

Nefcanto commented Dec 8, 2024

Hello

I upgraded to React 19 recently. I was using Helmet to dynamically add/remove fonts based on the selected locale to/from the header.
This is an example:

                        {
                            getLocale().key === supportedLocales.ar &&
                            <Helmet>
                                <link
                                    href="https://fonts.googleapis.com/css2?family=Noto+Kufi+Arabic:wght@100;200;300;400;500;600;700;800;900&display=swap"
                                    rel="stylesheet"
                                />
                                <link
                                    href="/Fonts/Arabic/style.css"
                                    rel="stylesheet"
                                    type="text/css"
                                />
                            </Helmet>
                        }

But now I don't see the links being added to the header anymore.

Can you please investigate?

@Nefcanto
Copy link
Author

It seems that <Helmet> tag works in the production environment after the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant