Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that uint64 -> int64 doesn't overflow #332

Open
tersec opened this issue Mar 10, 2021 · 0 comments
Open

Ensure that uint64 -> int64 doesn't overflow #332

tersec opened this issue Mar 10, 2021 · 0 comments

Comments

@tersec
Copy link
Contributor

tersec commented Mar 10, 2021 •
edited
Loading

nim-eth/eth/common/eth_types.nim

Lines 192 to 193 in be5e088

template toBlockNumber*(n: SomeInteger): BlockNumber =
int64(n)

With Nim 1.2.10 and newer, this would raise a RangeError/RangeDefect due to nim-lang/Nim#15210, when the block number's too high.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tersec