Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the neighboursAtDistances to be more suited for several distances #298

Open
kdeme opened this issue Sep 30, 2020 · 0 comments
Open
Labels
discoveryv5 Discovery v5 related issues

Comments

@kdeme
Copy link
Contributor

kdeme commented Sep 30, 2020

See comment here: https://github.com/status-im/nim-eth/pull/295/files#diff-99f5b2699612c1f155df8cbc305892e4R327

It was already not very well suited because of the "at distance", see: https://github.com/status-im/nim-eth/pull/295/files#diff-99f5b2699612c1f155df8cbc305892e4R333

But now for multiple distances, depending on how many we might and can return, it could be beneficial if we actually search for those specific distances instead of grabbing all neighbours and then checking what we got.

@kdeme kdeme added the discoveryv5 Discovery v5 related issues label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discoveryv5 Discovery v5 related issues
Projects
None yet
Development

No branches or pull requests

1 participant