Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting for discovery v5 messages and/or packets #284

Open
kdeme opened this issue Jul 23, 2020 · 1 comment
Open

Rate limiting for discovery v5 messages and/or packets #284

kdeme opened this issue Jul 23, 2020 · 1 comment
Labels
discoveryv5 Discovery v5 related issues security Issues that are certain to have security implications

Comments

@kdeme
Copy link
Contributor

kdeme commented Jul 23, 2020

Implement rate limits on the discovery messages / packets:

  • Handshake: one could continuously do handshakes with new peers (or same ones). This would be expensive for both sides, but can have implications on filling of the routing table. (See also discussion here: Adjust approach of randomNodes to a more lookup based system for providing peers #271)
  • Ping: The pong reply is relatively small and not expensive. But a handshake that goes before the ping might add the node to the routing table.
  • Findnode: The same applies regarding the handshake. But additionally, a nodes reply can be big and much more expensive. So this should be limited.

Based on this we need to look where to apply limits best. General packets, or something more subtle, or both.

@kdeme kdeme added discoveryv5 Discovery v5 related issues security Issues that are certain to have security implications labels Jul 23, 2020
@kdeme
Copy link
Contributor Author

kdeme commented Jul 23, 2020

Related NBC issue from audit: status-im/nimbus-eth2#1359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discoveryv5 Discovery v5 related issues security Issues that are certain to have security implications
Projects
None yet
Development

No branches or pull requests

1 participant