Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of stale nodes #262

Open
kdeme opened this issue Jun 30, 2020 · 0 comments
Open

Better handling of stale nodes #262

kdeme opened this issue Jun 30, 2020 · 0 comments
Labels
discoveryv5 Discovery v5 related issues enhancement New feature or request

Comments

@kdeme
Copy link
Contributor

kdeme commented Jun 30, 2020

After some tests in #261, it was decided to still replace nodes on first failure.

One scenario where this is troublesome is in case the own network connection drops, the routing table will get cleared.
Other is possibly when the own network connection is just very slow and/or flakey.
And as last, perhaps for usage with much less lookups, one might want a better control of the "stale" nodes.

One simple way to handle this is to flag a node on first failure not to be used for lookups/revalidation any more. And to do in the background (e.g. by some callback after first failure) some exponential back off pinging or just random pinging. (e.g. 5 times).

Should be tested properly though with looking at metrics, e.g. in bad network conditions.

@kdeme kdeme added discoveryv5 Discovery v5 related issues enhancement New feature or request labels Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discoveryv5 Discovery v5 related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant