-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash-order independent tests #550
Comments
hash order issue allowing nim-core to change its string hash function without making this test fail.
Sorry - I guess the line number of the test moved from the last release to the current HEAD of this repo. It was actually the area indicated by this PR. The question remains - when is the next release of chronos planned? This error is blocking the Nim CI which is blocking a Nim-2.2 release. |
Also, tagging @arnetheduck since the release cadance of this repo is somewhat slow compared to my impression of what @Araq means by "imminent", since he was the last person to tag a release, and since he said it should be merged ASAP, but that was ambiguous between "merged under its current non-disruptive |
Can you open a PR for this? The link leads to a commit in your repo. |
Done. Sorry - I actually did try to do that at first and something wasn't working then. This is the PR cross-linked for convenience: #551 |
The mentioned PR now passes the CI and just needs to be merged. So, I am closing this issue. |
tests/testhttpserver.nim
(850, 12) and (852) fail with a new string hasher because they assume a specific order.Any chance you guys can do something like @Vindaar did here in the next few days? Really just add a
.sorted
and put the@[]
in sorted order.The text was updated successfully, but these errors were encountered: