Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goalkeepers event location invalid #49

Open
xecarlox94 opened this issue Dec 21, 2024 · 0 comments
Open

Goalkeepers event location invalid #49

xecarlox94 opened this issue Dec 21, 2024 · 0 comments

Comments

@xecarlox94
Copy link

Hello there,

I am a big fan of your dataset and your work, and while analysing the data, I could not help to notice an invalid attribute in your data.

I have discovered it while doing a python script to get locations of goalkeeper events. There are some goalkeeper instances that do not have a location attribute, such as in a "shot save".

There is a quick example on match "68331.json" event "f337d0b1-540b-4697-bed6-17e22e3c24f6". The goalkeeper does a "shot save" but I get a "Not a number" in my pandas dataframe.

I believe this is an invalid value because it implies that the goalkeeper is somewhere in the pitch. This is an important issue because it has an high relevancy to the expected goal of a shot.

Is this something that you can correct?

Many thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant