Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding data as a parameter for indicator calculations #10

Open
dave-mills opened this issue Apr 18, 2024 · 0 comments
Open

Consider adding data as a parameter for indicator calculations #10

dave-mills opened this issue Apr 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@dave-mills
Copy link
Member

The current set of indicator calculations requires a data dataframe to exist. This is fine, as we can make sure it does before calling the functions. But I think it would be more flexible to pass in a data object as a parameter (similar to our graphics functions).

This way, we can pass whatever filtered dataset we need to calculate the indicators for one team, for many teams, for one group, etc.

This is also linked to #9

@dave-mills dave-mills added enhancement New feature or request question Further information is requested labels Apr 18, 2024
@dave-mills dave-mills added this to the Mid-term milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants