Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need select_one_from_external_file support? #17

Open
dave-mills opened this issue Apr 18, 2024 · 0 comments
Open

Do we need select_one_from_external_file support? #17

dave-mills opened this issue Apr 18, 2024 · 0 comments

Comments

@dave-mills
Copy link
Member

In the history of us doing weird things with ODK, we have veryy occasionally needed to use select_one_from_external_file with a csv file generated from a database. This means doing something special to make sure it is in the valid format:

Copied from a previous version:

        // If the csv file is used with "select_one_from_external_file" (or multiple) it must not have any enclosure characters:
        if (isset($lookup['external_file']) && $lookup['external_file'] === '1') {
            $contents = Storage::disk(config('filament-odk-link.storage.xlsforms'))->get($filePath);
            $contents = Str::of($contents)->replace('"', '');

            Storage::disk(config('filament-odk-link.storage.xlsforms'))->put($filePath, $contents);
        }

TODO: consider if we still need this, and implement it if we do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant