Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine constraint string. #889

Merged
merged 1 commit into from
Nov 19, 2024
Merged

State machine constraint string. #889

merged 1 commit into from
Nov 19, 2024

Conversation

Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Nov 14, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Nov 14, 2024
@Alon-Ti Alon-Ti marked this pull request as ready for review November 14, 2024 14:27
@Alon-Ti Alon-Ti force-pushed the alont/state-machine-expr branch 2 times, most recently from c18ec88 to dec69b6 Compare November 17, 2024 12:20
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: a0c3a0d Previous: f6214d1 Ratio
merkle throughput/simd merkle 30982555 ns/iter (± 474797) 14690867 ns/iter (± 434150) 2.11

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

@Alon-Ti Alon-Ti mentioned this pull request Nov 19, 2024
@Alon-Ti Alon-Ti changed the base branch from alont/formal-expr-logup1 to graphite-base/889 November 19, 2024 11:56
@Alon-Ti Alon-Ti changed the base branch from graphite-base/889 to dev November 19, 2024 11:57
@Alon-Ti Alon-Ti merged commit 77de4d7 into dev Nov 19, 2024
18 of 19 checks passed
Copy link
Contributor Author

Alon-Ti commented Nov 19, 2024

Merge activity

  • Nov 19, 8:08 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants