Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket subscription methods naming incosistency #248

Open
FabijanC opened this issue Nov 12, 2024 · 0 comments
Open

Websocket subscription methods naming incosistency #248

FabijanC opened this issue Nov 12, 2024 · 0 comments

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Nov 12, 2024

In JSON-RPC API v0.8.0, why does only newHeads subscription have "new" in its name: starknet_subscribeNewHeads, starknet_subscriptionNewHeads? E.g. the events are also new, but there's no "new" in starknet_subscribeEvents and starknet_subscriptionEvents.

I've been told that Starknet tries to follow Ethereum's subscription API, but it's quite different from it:

  1. There's only one subscription method there (eth_subscribe) with the subscription type specified in parameters.
  2. newHeads also covers chain reorg (but at least it's also called newHeads).
  3. pendingTransactions is called newPendingTransactions
  4. events is called logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant