chore(batcher): add next_block_info method to block builder factory

[ArniStarkware]

Refactor towards getting block info from consensus.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(batcher): add next_block_info method to block builder factory #2231 👈 (View in Graphite)
• chore(batcher): remove block metadata member from block builder factory #2230
• chore(blockifier): move block info to starknet api #2246 : 1 other dependent PR (#2237 )
• chore(blockifier): move GasPrices to snapi #2245
• feat(blockifier): derive serialize for block info #2244
• chore(blockifier): rename the getters for the gas prices struct #2269
• chore(blockifier): separate create and validate logic on gas prices #2243
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 5.18%. Comparing base (a33b3cc) to head (3b0a743).

Files with missing lines	Patch %	Lines
crates/starknet_batcher/src/block_builder.rs	0.00%	18 Missing ⚠️

Additional details and impacted files

@@                                         Coverage Diff                                         @@
##           arni/batcher/block_builder_factor/refactor/remove_block_metadata   #2231      +/-   ##
===================================================================================================
- Coverage                                                              5.18%   5.18%   -0.01%     
===================================================================================================
  Files                                                                   146     146              
  Lines                                                                 16981   16986       +5     
  Branches                                                              16981   16986       +5     
===================================================================================================
  Hits                                                                    880     880              
- Misses                                                                16027   16032       +5     
  Partials                                                                 74      74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[Yael-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dafnamatsry)

---

crates/starknet_batcher/src/block_builder.rs line 319 at r1 (raw file):

    ) -> BlockBuilderResult<TransactionExecutor<PapyrusReader>> {
        let block_builder_config = self.block_builder_config.clone();
        // TODO(Arni): Get as a parameter for this function.

why no take the block number as you did here?

Code quote:

// TODO(Arni): Get as a parameter for this function.

[ArniStarkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)

---

crates/starknet_batcher/src/block_builder.rs line 319 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

why no take the block number as you did here?

This TODO is no longer relevant. I should removed it.
I don't want to pass the height separately, as it is a part of the block_info.

[Yael-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dafnamatsry)

---

crates/starknet_batcher/src/block_builder.rs line 302 at r2 (raw file):

        BlockInfo {
            block_number: height,
            block_timestamp: BlockTimestamp(chrono::Utc::now().timestamp().try_into().unwrap()),

if you remove this error, you also need to remove it from the error types.

Code quote:

.unwrap())

[ArniStarkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)

---

crates/starknet_batcher/src/block_builder.rs line 302 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

if you remove this error, you also need to remove it from the error types.

Now not using unwrap() in production code.
Done.

[Yael-Starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @dafnamatsry)

[alonh5]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @dafnamatsry, and @Yael-Starkware)

---

a discussion (no related file):
Also no need for this intermediate PR. I'm having trouble keeping track. Above PR #2246 there could be one PR passing the block info from the consensus in the input (which is PR #2237 with some additions).

[ArniStarkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)

---

a discussion (no related file):

Previously, alonh5 (Alon Haramati) wrote…

Also no need for this intermediate PR. I'm having trouble keeping track. Above PR #2246 there could be one PR passing the block info from the consensus in the input (which is PR #2237 with some additions).

This PR is indeed no longer relevant.

[ArniStarkware]

This PR is no longer relevant.