-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ordered insertMany incorrectly fails if an row has pre-execution error #1672
Comments
It was later clarified that if by "faulty row" one means "a row with a wrong type", then the fact that no insertions occur is by design: Tables do preemptive all-rows data validation and this is the expected behaviour. |
re-open as we are discussing |
moved out of the dec-hotfix because it is not a blocking problem, and though small the change is deep and I want to make sure we get it correct. |
moved to To-Do because we are working on it. @Yuqi-Du I think the fix is like you have, but simplier. When the processing is sequential the only test is that we fail if the current attempt is in error state. Also, I would like to have unit tests to test the behaviour |
Symptom: insertMany on tables, when
ordered=True
and there's a faulty row in mid-list, does not insert even those coming prior to that one.This is at odds with Collections (ordered=true), where the docs are inserted sequentially until the erroring one.
Also in that case the response has no
"status"
field at all.(first reported here).
The text was updated successfully, but these errors were encountered: