Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Native 0.73.* #15

Open
KevinvdBurg opened this issue Feb 9, 2024 · 3 comments
Open

Upgrade to React Native 0.73.* #15

KevinvdBurg opened this issue Feb 9, 2024 · 3 comments

Comments

@KevinvdBurg
Copy link

Hi,

Thanks for all the great work on this package.

I'm trying to update my project to React Native 0.73.4 and Expo 50 and I'm getting the follow error.=

npm ERR! node_modules/react-native
npm ERR!   react-native@"0.73.4" from the root project
npm ERR!   peer react-native@"*" from @devvie/[email protected]
npm ERR!   node_modules/@devvie/bottom-sheet
npm ERR!     @devvie/bottom-sheet@"^0.3.0" from the root project
npm ERR!   29 more (@expo/metro-runtime, ...)

Is it possible to upgrade this package to the latest version?

Thanks!

@stanleyugwu
Copy link
Owner

Oh! Thanks for letting me know, I'll bump to latest versions ASAP

@stanleyugwu
Copy link
Owner

Hey @KevinvdBurg ,

This issue most likely caused by un-versioned peer dependencies react and react-native.

Starting from npm 7+ the default behavior for peer dependencies have changed.
From v7 up, packages need to specify a particular version for its peer dependencies, that's why npm throws an error when it sees * as a version.

I'll make the versions specific before the next release, but for now I guess you can use the --legacy-peer-deps flag to skip those error

@stanleyugwu
Copy link
Owner

Just fyi, I pushed the version bumps to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants