Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Next <weekday>" is sometimes expressed as an absolute date #782

Open
gcampax opened this issue Sep 12, 2021 · 0 comments
Open

"Next <weekday>" is sometimes expressed as an absolute date #782

gcampax opened this issue Sep 12, 2021 · 0 comments
Assignees
Labels
bug Something isn't working i18n Translation / internationalization issues P2 We need to fix it (backlog)

Comments

@gcampax
Copy link
Contributor

gcampax commented Sep 12, 2021

The (English postprocessing) NLG code recognizes that if the date is less than a week apart, we should say "next " (next Monday, next Tuesday, etc.). This logic seems to be broken when the date is exactly one week apart. That is, on Sunday, when talking about "next Sunday at XX:XX am" , we say an absolute date ("on September 19 at XX:XX").

This is causing stanford-oval/thingpedia-common-devices#431 which makes the scenario tests fail intermittently.

@gcampax gcampax added bug Something isn't working i18n Translation / internationalization issues labels Sep 12, 2021
@gcampax gcampax added the P2 We need to fix it (backlog) label Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working i18n Translation / internationalization issues P2 We need to fix it (backlog)
Projects
None yet
Development

No branches or pull requests

2 participants