Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad confirmation message to "check if the lights are on" #775

Open
gcampax opened this issue Sep 2, 2021 · 1 comment
Open

Bad confirmation message to "check if the lights are on" #775

gcampax opened this issue Sep 2, 2021 · 1 comment
Assignees
Labels
bug Something isn't working P2 We need to fix it (backlog) templates Issues with templates and the state machine

Comments

@gcampax
Copy link
Contributor

gcampax commented Sep 2, 2021

If the agent is unsure about that question, it will prompt with:

Did you mean get the are the Corner lamp top lights off??
which is ungrammatical.

We need to rearrange the dataset so that the phrases that work in the NLG are first.

Raw log:

[04:51:34.401371] on_message (../src/stt.cpp:90): STT text: Computer check if the lights are on.
[04:51:34.401486] on_message (../src/stt.cpp:104): STT mangled: check if the lights are on.
[04:51:34.401660] sendJSON (../src/wsclient.cpp:53): [SERVER WS] sending: {"type":"command","text":"check if the lights are on."}** Message: Received message: {"type":"command","command":"check if the lights are on.","id":89}

** Message: Received message: {"type":"text","text":"Did you mean get the are the Corner lamp top lights off??","icon":"org.thingpedia.iot.light-bulb","id":90}

[04:51:35.383586] dispatch_queue (../src/audioplayer.cpp:239): Now playing: Did you mean get the are the Corner lamp top lights off??
** Message: Received message: {"type":"askSpecial","ask":"yesno"}
@gcampax
Copy link
Contributor Author

gcampax commented Sep 7, 2021

This is actually a bug in genie-toolkit, it should not use a "program" primitive template to fill a query noun phrase.

@gcampax gcampax transferred this issue from stanford-oval/thingpedia-common-devices Sep 7, 2021
@gcampax gcampax added bug Something isn't working P2 We need to fix it (backlog) templates Issues with templates and the state machine labels Sep 7, 2021
@gcampax gcampax assigned gcampax and unassigned almakantara Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 We need to fix it (backlog) templates Issues with templates and the state machine
Projects
None yet
Development

No branches or pull requests

2 participants