-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard action Ruby version is different from application Ruby #9
Comments
I noticed while investigating standardrb#9 that the Ruby version is hardcoded. In lieu of fixing that just yet I thought I could at least bring it up to date.
@willtcarey if I understand you right, I think setting a https://github.com/standardrb/standard?tab=readme-ov-file#configuring-ruby_version |
That's a great point. My Ruby version is actually stored in my Gemfile.lock so maybe I need to look into why Rubocop wasn't picking that up. What I wound up going with involved passing a ruby version argument to this action and using that version when installing Standard and running. It worked out alright, but I'd like to remove that complexity and have Standard/Rubocop pick up my Ruby version automatically like it should be able to.
|
But anyways, it's good to know that despite the Ruby version being hardcoded, the action should be able to check lesser Ruby versions |
Bug Report
Describe the bug
Standardrb action reports different linting errors then we get locally because of Ruby version mismatches.
To Reproduce
Steps to reproduce the behavior:
standard-ruby-action/Dockerfile
Line 1 in f533e61
Locally we have code like the following which does not report a lint error.
When standardrb runs in Github Actions this code does report a linting error because this violates Standard's rules in Ruby 3.2.
Expected behavior
We expect to be able to run standardrb from the version of Ruby specified in our application so that the linting errors will match.
Action Version & Workflow File
Workflow File
The text was updated successfully, but these errors were encountered: