-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of ESM imports instead of CommonJS #171
Comments
Blocked by microsoft/TypeScript#44501 and jestjs/jest#9430.
|
Not it! Tried helping out here, but i don't like typescript... or ts-node, ts-jest Lines 10 to 11 in 3a58e8a
This can still be a typescript project but it dose not have to be written with typescript syntax... would it be crazy to go back to vanilla js and use jsDoc instead? just use tsc to generate d.ts files from plan js/jsDoc. |
I have some experience with getting ESM, TypeScript, and Jest so I'd be happy to take a look at this. I believe that this can work without the two linked blockers actually... That being said, I love TypeScript a lot, but I don't think that we have to use it here. In fact, I think that I would prefer that I would never do a big project without TypeScript today, but for small utilities and libraries I think it's easier to do without it... |
Sure, if you know how to do it, feel free to open a PR. 🚀
I agree, The main differences between In my opinion: We should rewrite completely Would like to know the opinion of @toddbluhm. |
Hey, Sorry that I have been out for a while...busy with life. I see this project as owned by the standard team. As such if you guys think it would be better to rewrite in vanilla js that is good with me. The reason for adding --project was to allow setting the location of the project file on the cli because a project file is necessary for a lot of the type checking. This is something unique to typescript that is not unique to the other linters. If you guys don't think the extra flags are necessary then by all means deprecate them 😄 Hopefully that adds clarity. I'll be around more if you need help or code reviews. |
Is there any future planning for the project? @toddbluhm @divlo |
Ideally, we want to update I don't want/have the time personally, to do the work for this, but I will be happy to review any PR for this. |
We should use ESM imports instead of CommonJS.
See: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
It would offer a smoother transition when
standard-engine
has been migrated completely to ESM, see: standard/standard-engine#251.The text was updated successfully, but these errors were encountered: