Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove print utility #1289

Open
mitzimorris opened this issue Aug 5, 2024 · 1 comment
Open

remove print utility #1289

mitzimorris opened this issue Aug 5, 2024 · 1 comment

Comments

@mitzimorris
Copy link
Member

Summary:

The print command has been marked deprecated since 2015 (!).
It needs to be removed because it depends on methods in stansummary_helper.hpp; changing these as part of #1263 breaks print.

Description:

Stan PR stan-dev/stan#3305 introduces a new object, chainset which is easier to deal with than the data structures used by chains. This refactoring made it much easier to implement the computation of split-rank normalized ESS and Rhat, giving separate estimates of for the bulk and tails of the posterior. In order to add these diagnostics to stansummary, it is necessary to use a chainset object everywhere, instead of a chains object. The print utility uses functions stansummary_helper; changes to the function signatures breaks print.

IMO, it's not worth the programming effort to further patch print. Can we remove it in the next release?

Current Version:

v2.35.0

@bob-carpenter
Copy link
Contributor

Agreed. please remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants