Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera implementation for p5.js 1.10.0 #218

Closed
TiborUdvari opened this issue Aug 30, 2024 · 2 comments · Fixed by #223
Closed

Fix camera implementation for p5.js 1.10.0 #218

TiborUdvari opened this issue Aug 30, 2024 · 2 comments · Fixed by #223
Assignees

Comments

@TiborUdvari
Copy link
Collaborator

TiborUdvari commented Aug 30, 2024

Starting from version 1.10.0 p5.js (finally) separates model and view matrices. This breaks how p5XrViewer handles the camera and needs to be updated.

Details in this merged PR: processing/p5.js#6761

@TiborUdvari TiborUdvari self-assigned this Aug 30, 2024
@TiborUdvari TiborUdvari changed the title Fix camera implementation for p5.js 0.1.10 Fix camera implementation for p5.js 1.10.0 Sep 2, 2024
@TiborUdvari
Copy link
Collaborator Author

Using the new separated matrices work, but there was a new issue introduced in the line renderer, affecting small coordinates ex. real world coordinates expressed in meters. Details here:

processing/p5.js#7200

Might need to temporarily use older vertex shader that was working well before.

@TiborUdvari
Copy link
Collaborator Author

This was also an issue affecting all sketches, the new behaviour that was introduced activated the linePerspective by default in p5.xr which was not the case, this broke older sketches, as the lines could be really thick and made them look like a bug. processing/p5.js#7209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant