Add session_id to headers for all HTTP requests to sphinx-tribes backend #820
+250
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a new release for sphinx-tribes because that is why the tests are failing rn https://github.com/stakwork/sphinx-tribes/releases/tag/v0.1.95 |
kevkevinpal
reviewed
Dec 30, 2024
src/store/main.ts
Outdated
| @@ -218,7 +218,8 @@ export class MainStore { | |||
| body: JSON.stringify(body), | |||
| headers: { | |||
| 'x-jwt': info.tribe_jwt, | |||
| 'Content-Type': 'application/json' | |||
| 'Content-Type': 'application/json', | |||
| session_id: this.sessionId | |||
There was a problem hiding this comment.
is session_id supposed to be wrapped in quotes?
aliraza556
force-pushed
the
feature/add-session-id-every-request
branch
from
d6cddfa to
a4e2119
Compare
|
can you try updating to I saw that using an underscore is fine but nginx will ignore headers with an underscore so that might be causing the issue, I'll create a new release after merging the tribes PR |
@kevkevinpal Sure |
kevkevinpal
force-pushed
the
feature/add-session-id-every-request
branch
from
af11fa0 to
530f0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link: stakwork/sphinx-tribes#2305
Closed: stakwork/sphinx-tribes#2305
Type of change
https://www.loom.com/share/31a1109ea45e4efdaae67b2422e03e50
Please delete options that are not relevant.
Checklist before requesting a review