Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger util for sphinx-tribes/routes #2256

Closed
Tracked by #2168
kevkevinpal opened this issue Dec 20, 2024 · 2 comments · Fixed by #2257
Closed
Tracked by #2168

Use logger util for sphinx-tribes/routes #2256

kevkevinpal opened this issue Dec 20, 2024 · 2 comments · Fixed by #2257
Assignees

Comments

@kevkevinpal
Copy link
Contributor

kevkevinpal commented Dec 20, 2024

Description

We want to replace in sphinx-tribes/routes where we use fmt.Print{f,ln}

grep -nri "fmt\.Print" ./routes/
./routes/index.go:111:          fmt.Println("Listening on port " + PORT)
./routes/index.go:113:                  fmt.Println("server err:", err.Error())
./routes/index.go:153:          fmt.Println("Jarvis configuration not found, skipping error reporting")
./routes/index.go:161:          fmt.Printf("Failed to marshal edge list: %v\n", err)
./routes/index.go:167:          fmt.Printf("Failed to create Jarvis request: %v\n", err)
./routes/index.go:180:          fmt.Printf("Failed to send error to Jarvis: %v\n", err)
./routes/index.go:186:          fmt.Println("Successfully sent error to Jarvis")
@aliraza556
Copy link
Contributor

@kevkevinpal Assign me?

@saithsab877
Copy link
Contributor

@kevkevinpal I can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants