Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Investigate V2 Encoding not deploying correctly on Staging #646

Open
humansinstitute opened this issue Nov 15, 2024 · 6 comments
Open
Assignees
Labels
Bounties bug Something isn't working

Comments

@humansinstitute
Copy link
Collaborator

humansinstitute commented Nov 15, 2024

Follow up integration bug on #635
On Merge of #640 the Testing on Staging is failing as the copied pubkey is being returned with the corrupt style of encoding.

- Observed On Staging  ->  <part1>:<part2>_<part3>    
- Expected / Correct      ->  <part1>_<part2>_<part3>   
@aliraza556
Copy link
Contributor

aliraza556 commented Nov 15, 2024

@humansinstitute, Please assign me?

@saithsab877
Copy link
Contributor

saithsab877 commented Nov 15, 2024

@humansinstitute, assign me?

@saithsab877
Copy link
Contributor

Hi @humansinstitute,

Please check the demo:

https://www.loom.com/share/1a55f79efdf04e06a187f3cba30b7f9c

Currently, the V2 pubkey is correctly encoded on the staging side. Once the changes are merged and a new release is made (e.g., https://github.com/stakwork/sphinx-tribes-frontend/releases/tag/v0.0.34 ), you can verify that the V2 pubkey is reflected correctly here: https://people-test.sphinx.chat/p/csk586cnuku6oosk3r90/workspaces

Hi @elraphty, could you please release the new changes on the frontend side?

@humansinstitute
Copy link
Collaborator Author

@elraphty Am I missing something here?

The PR is merged and correctly built, but when I test in staging I don't see this behaivour.

Everything other bug where we've merged into main is then rebuilt and deployed on staging for testing without needing to be tagged as a release, so I don't see why this would be different?

Two question:

  1. Am I missing something here about the release process - I expect this should be available in staging?
  2. Can you review Fix: Update Sphinx Links with Correct V2 Pubkey Encoding for Adding People from Registry #640 and see if I'm missing with the logic and why this may not work on staging, but appears correct on Localhost?

@elraphty
Copy link
Collaborator

@elraphty Am I missing something here?

The PR is merged and correctly built, but when I test in staging I don't see this behaivour.

Everything other bug where we've merged into main is then rebuilt and deployed on staging for testing without needing to be tagged as a release, so I don't see why this would be different?

Two question:

  1. Am I missing something here about the release process - I expect this should be available in staging?
  2. Can you review Fix: Update Sphinx Links with Correct V2 Pubkey Encoding for Adding People from Registry #640 and see if I'm missing with the logic and why this may not work on staging, but appears correct on Localhost?

Okay, I will take a look.

@elraphty
Copy link
Collaborator

2. Fix: Update Sphinx Links with Correct V2 Pubkey Encoding for Adding People from Registry #640

@humansinstitute, I tested this on people-test.sphinx.chat, it worked for V2 users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounties bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants