-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relay change that broke proxy #584
Comments
https://github.com/stakwork/sphinx-relay/blob/master/src/tests/controllers/tribe3Messages.test.ts some of these tests dont even use proxy which maybe the reason this change passed integration testing |
Adding some new test changes here, will check with the change that we reverted to make sure the test fails |
@Evanfeenstra looks like the cryptian issues were not just on the proxy node looks like the automated tests are failing to build the modules aswell https://github.com/stakwork/sphinx-relay/actions/runs/4085405458/jobs/7043333139 |
@kevkevinpal you can set |
Ok thanks @Evanfeenstra looks like its building and passing now, going to add the change that broke proxy to the PR to get the test to fail |
This add more proxy users stakwork/sphinx-stack#56 but it seems this wont fix the issue we had since it was trying to connect the already existing proxy users to mqtt but the way sphinx-stack is setup is that it generate new proxy users. I can explore to see if we can just have an existing state in proxy that we can startup from |
closing this cause we solved the issue |
This change broke proxy https://github.com/stakwork/sphinx-relay/pull/523/files
not sure why the test didn't break because users were not able to receive mqtt messages.
We should try applying these changes and getting the tests to fail
The text was updated successfully, but these errors were encountered: