Backport upstream message bar changes #831
Open
+93
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parts of this PR are a subset of general alert translation removal of HSLdevcom@7887d10
andreashelms
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adopts upstream changes to message bar alerts handling.
This is i.e. required to have messages appear for the German Locale.
Fixes #830.
Note: This Change is only a subset of a general improvement in alert localisation handling, which has been implemented in
HSLdevcom@7887d10 and which should be pulled as well.
@stadtnavi/stadtnavi whit this PR, severe alerts will be displayed in the message bar.
There are a couple of follow up questions we should discuss and possibly address in subsequent tickets, e.g. styling of the disruption banner, is it helpful to display a link "More information" that currently only directs to VVS home page (no more specific info is available from VVS)