-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General code clean-up / Remove legacy code #294
Comments
Marak
added a commit
that referenced
this issue
Oct 24, 2017
Marak
added a commit
that referenced
this issue
Nov 2, 2017
Marak
added a commit
that referenced
this issue
Nov 7, 2017
* Adds JSON errors for uncaught hook.run errors * Removes legacy execute() path * Fixes incorrect 301 status codes * Minor style and config updates * Adds code comments
Marak
added a commit
that referenced
this issue
Nov 8, 2017
* Removes legacy Hook methods * Removes code that is now in `microcule` * Removes code for loading views / presenters * All tests passing
Marak
added a commit
that referenced
this issue
Nov 20, 2017
* Moves user login logic to user resource * Refactors duplicate login code * Improves tests to check for internal api key * Removes manually emitted login event * Adds tests for account billing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a bit of dead code / commented out code / un-used files in the repository.
Much of this seems left over from before we created
microcule
and was left in at the time to help with the migration. There also seems to be a bit of commented outoys
code which should be removed.I'm opening this issue as a general issue to track the removal of legacy code.
The text was updated successfully, but these errors were encountered: