Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset rate limiting by IP address every 24 hours #37

Open
markmhendrickson opened this issue Jun 12, 2020 · 2 comments
Open

Reset rate limiting by IP address every 24 hours #37

markmhendrickson opened this issue Jun 12, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@markmhendrickson
Copy link

This would prevent both PBC and non-PBC developers from getting blocked for a lifetime based on their IP addresses, forcing them to switch to another network as they invest more time developing and testing with new usernames.

@markmhendrickson markmhendrickson added the enhancement New feature or request label Jun 12, 2020
@wileyj
Copy link
Contributor

wileyj commented Jun 12, 2020

@kantai is this possible in the config or via restarting the process?
or is this something that is stored in the local db ?

@kantai
Copy link
Member

kantai commented Jun 12, 2020

This would require some updates to the IP rate-limiting logic. Currently, the registrar stores the IP for each request in its local DB, and just counts the entries associated with an IP address to figure out if they have crossed the limit. To reset this on some configurable interval, we'd need to update that query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants