Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/invalid tx #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix/invalid tx #17

wants to merge 4 commits into from

Conversation

yknl
Copy link
Collaborator

@yknl yknl commented Oct 30, 2020

This PR fixes a bug where invalid STX transactions (valid BTC transaction but rejected by Stacks core node) shows up as a valid STX transaction in the wallet transaction history. This only occurs when the account has no prior transaction history.

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @person1 or @Person2

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants