Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code fallbacks don't work for anon if WebLN enabled #1758

Open
1 task done
ekzyis opened this issue Dec 23, 2024 · 0 comments
Open
1 task done

QR code fallbacks don't work for anon if WebLN enabled #1758

ekzyis opened this issue Dec 23, 2024 · 0 comments
Labels

Comments

@ekzyis
Copy link
Member

ekzyis commented Dec 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

If the WebLN wallet was enabled and we switch to anon, anon will also use the WebLN wallet because it only looks at wallet:webln (not scoped to user id).

However, if the WebLN prompt was canceled, we won't show a QR code because anon can't retry invoices.

This means that following attempts will simply do nothing and anon looks broken because WebLN prompts don't open again once they were canceled. Only a page reload brings back the WebLN prompt but still not possible to fallback to a QR code.

I think anons should be able to use WebLN but that we only try it if it was enabled while signed in is weird.

Screenshots

No response

Steps To Reproduce

  1. Enable WebLN wallet
  2. Switch to anon
  3. Try to post something
  4. Cancel WebLN prompt

Expected behavior

Anon can fallback to QR code if WebLN enabled or gets immediately shown a QR code

Logs

No response

Device information

No response

Additional context

No response

@ekzyis ekzyis added the bug label Dec 23, 2024
@ekzyis ekzyis changed the title Anon canceled WebLN payments can't retry QR code fallbacks don't work for anon if WebLN enabled Dec 23, 2024
@stackernews stackernews deleted a comment Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant