Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new comment indicator shows after I leave a new comment #1754

Closed
huumn opened this issue Dec 21, 2024 · 2 comments
Closed

new comment indicator shows after I leave a new comment #1754

huumn opened this issue Dec 21, 2024 · 2 comments

Comments

@huumn
Copy link
Member

huumn commented Dec 21, 2024

I thought we previously had an issue for this, but maybe not. Regardless, this is still an issue. I think useItemSubmit forgot to update the time.

@Soxasora
Copy link
Member

I was commenting around SN to test this, it seems that it happens only in prod.
I followed cache updating via Apollo devtools and lastCommentAt gets updated correctly when I create a new comment

@huumn
Copy link
Member Author

huumn commented Dec 27, 2024

Ah this is happens only for non-custodial comments afaict, because lastCommentAt is set to now() in onPaid which runs asynchronously in another tx after the item is created in perform.

The solution would probably be to set lastCommentAt = GREATEST(lastCommentAt, comment.created_at).

@huumn huumn self-assigned this Dec 28, 2024
@huumn huumn closed this as completed in 74f771a Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants