Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attached wallet fallbacks on failure in order of priority #1494

Closed
huumn opened this issue Oct 18, 2024 · 2 comments · Fixed by #1688
Closed

attached wallet fallbacks on failure in order of priority #1494

huumn opened this issue Oct 18, 2024 · 2 comments · Fixed by #1688
Assignees
@riccardobl @ekzyis
Labels
feature new product features that weren't there before question further information is required wallets
Milestone
November 5

Comments

@huumn
Copy link
Member

huumn commented Oct 18, 2024

For zaps, this is more complicated than it sounds because either party in a p2p zap can cause it to fail and we only want to "fallback" for the failing side.

Also, if all fallbacks fail for a zap, should the last resort be cowboy credits?
@huumn huumn added feature new product features that weren't there before question further information is required wallets labels Oct 18, 2024
@riccardobl riccardobl self-assigned this Oct 18, 2024
@riccardobl riccardobl mentioned this issue Oct 20, 2024
Closed
@ekzyis ekzyis added this to the Nov 5 milestone Oct 23, 2024
@riccardobl riccardobl mentioned this issue Oct 28, 2024
Closed
13 tasks
@ekzyis ekzyis mentioned this issue Nov 23, 2024
Merged
18 tasks
@ekzyis ekzyis self-assigned this Nov 28, 2024
This was referenced Dec 2, 2024
Draft
Open
Merged
@ekzyis
Copy link
Member

ekzyis commented Dec 6, 2024

Also, if all fallbacks fail for a zap, should the last resort be cowboy credits?

This is how it currently works in #1688. I think we mentioned this might be a setting but it's not for now.

@huumn
Copy link
Member Author

huumn commented Dec 6, 2024

I don't think it will end up needing to be a setting, but we can see how people react over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riccardobl riccardobl

@ekzyis ekzyis

Labels
feature new product features that weren't there before question further information is required wallets
Projects
None yet
Milestone
November 5
3 participants
@riccardobl @ekzyis @huumn