Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter set in fig.add_subplot() in OffPolicyEvaluation.visualize_off_policy_estimates_of_multiple_policies #174

Open
MotoShin opened this issue Jun 17, 2022 · 2 comments

Comments

@MotoShin
Copy link

Isn't the parameter for this part len(self.ope_estimators_) instead of len(action_dist_list) ?
With the current code, I think that the output image will not be normal unless len(self.ope_estimators_) and len(action_dist_list) are the same number.

ax = fig.add_subplot(len(action_dist_list), 1, i + 1)

@MotoShin
Copy link
Author

Perhaps there is a similar problem here.

ax = fig.add_subplot(len(action_by_evaluation_policy_list), 1, i + 1)

ax = fig.add_subplot(len(action_dist_list), 1, i + 1)

@jilljenn
Copy link

jilljenn commented Feb 7, 2024

I think there is a bigger problem with this function.

Screenshot 2024-02-08 at 04-56-40 OBP - Jupyter Notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants