Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid inputs in sst-macro/configurations #620

Open
jpkenny opened this issue Jul 15, 2021 · 1 comment
Open

invalid inputs in sst-macro/configurations #620

jpkenny opened this issue Jul 15, 2021 · 1 comment
Labels

Comments

@jpkenny
Copy link
Contributor

jpkenny commented Jul 15, 2021

There are input snippets in sst-macro/configurations that no longer produce valid inputs.

For example "router {name = minimal}" in exa2_pisces.ini is no longer valid because routers are now specific to topologies -- to run a torus you need to use "router {name = torus_minimal}". (And, yes, router type is no longer a generalizable thing that can be stuck into a "snippet" like this.)

We shouldn't distribute example inputs that aren't tested.

@jpkenny jpkenny added the bug label Jul 15, 2021
@burlen
Copy link

burlen commented Dec 14, 2023

I found many such issues so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants