Skip to content
This repository has been archived by the owner on Jun 10, 2018. It is now read-only.

Serve from Windows with normal '/'s in your require paths #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spiralman
Copy link

This not only fixes the raw '/' in getRelativePath, but also replaces the backslashes you get from Windows with forward slashes when generating the filename key for the compiled module function.

This lets you serve your files from Windows, but still use '/' in your require calls. Using '/' on the client side is nice because it's symmetrical with the server side (node accepts '/' in require on Windows) and lets you serve your files from Windows and Posix. Pus '/' is the One True Path Separator.

All tests pass (on Windows and Posix), but I cheated on "paths may be symlinks" since Windows doesn't really support symlinks.

Review on Reviewable

@Hubro
Copy link

Hubro commented Jul 19, 2012

+1 PULL THIS - Seriously this completely fixed my build issues in Windows

@konstantinvlasenko
Copy link

+1

1 similar comment
@ngryman
Copy link

ngryman commented Jan 30, 2013

+1

@benjajaja
Copy link

+1 fixes windows

@TheRightChoyce
Copy link

+1 fixed my issue on windows

@rbardini
Copy link

+1

@cyrilis
Copy link

cyrilis commented May 30, 2013

Thank you! Fixed my issue.

@kylekatarnls
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants