This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Serve from Windows with normal '/'s in your require paths #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only fixes the raw '/' in getRelativePath, but also replaces the backslashes you get from Windows with forward slashes when generating the filename key for the compiled module function.
This lets you serve your files from Windows, but still use '/' in your require calls. Using '/' on the client side is nice because it's symmetrical with the server side (node accepts '/' in require on Windows) and lets you serve your files from Windows and Posix. Pus '/' is the One True Path Separator.
All tests pass (on Windows and Posix), but I cheated on "paths may be symlinks" since Windows doesn't really support symlinks.