Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin_tone variable assigned by character setup often breaks #65

Open
ghost opened this issue Aug 25, 2015 · 8 comments
Open

Skin_tone variable assigned by character setup often breaks #65

ghost opened this issue Aug 25, 2015 · 8 comments

Comments

@ghost
Copy link

ghost commented Aug 25, 2015

Some characters end up spawning in with a negative skin_tone, changing them from being dark-skinned to incredibly albino

@ghost
Copy link
Author

ghost commented Aug 27, 2015

Did some digging: s_tone is, at a few points in the code, reversed and added to 35. This is typically represented by the end of any point where a character sets their skin tone having "s_tone = -s_tone + 35" appended. Simply changing all instances of -s_tone to s_tone did not work.

@walmartcheapo
Copy link

Reported skin-tone causing an issue is 120.

@Ryan784
Copy link

Ryan784 commented Aug 31, 2015

As of right now setting the skin tone to 120 doesn't cause this bug, when I try to test it.

@BlueNexus
Copy link
Collaborator

It would be work talking to Crystal, the person who originally reported this bug.

@Ryan784
Copy link

Ryan784 commented Sep 3, 2015

Having tested skin colors ranging from 1-220, and with the skin tones always sticking, I can either say this bug no longer exists - or that at the very least, it's occurrence is unlikely.

Until it happens again, and someone can see/document it in game, I don't know if we can "fix" it, if it even exists.

@BlueNexus
Copy link
Collaborator

I've seen it in-game. Ask Crystal.

@Isratosh
Copy link
Collaborator

This happened again. Shown here is what the s_tone should've been, Shown here is what it actually was.

@DJPantheris
Copy link

Guys, due to this being open a long time, the priority should be escalated to High.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants