Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall on Windows shows errors and leaves remnants #2

Open
dokempf opened this issue Apr 17, 2024 · 8 comments
Open

Uninstall on Windows shows errors and leaves remnants #2

dokempf opened this issue Apr 17, 2024 · 8 comments

Comments

@dokempf
Copy link
Member

dokempf commented Apr 17, 2024

The folder can only be fully removed if it is not used by other applications. Maybe the problem is with Jupyter sessions running in the background (you can tell from the increasing port number that they never correctly close).

@dokempf
Copy link
Member Author

dokempf commented Apr 17, 2024

Screenshot 2024-04-17 170514

@dokempf
Copy link
Member Author

dokempf commented Apr 17, 2024

This happens even when uninstall is triggered right after freshly installing. It fails to run the scripts pre_uninstall, rmpath and rmreg. Given that pre_uninstall.bat is empty, I am assuming it is looking in the wrong place for these.

@dokempf
Copy link
Member Author

dokempf commented Apr 17, 2024

Looking through the issue list at constructor, it seems like uninstalling is quite a rabbit hole. We might best document a way of doing it manually for users and not rely on the provided uninstall capabilities.

@dokempf
Copy link
Member Author

dokempf commented Apr 18, 2024

I digged through the NSIS log and it seems like the actual uninstallation is implemented in a Python script called _nsis, most likely written by constructor. That would actually make it a debuggable thing:

DetailPrint: "Running pre_uninstall scripts..."
SetDetailsPrint: listonly
!insertmacro: _If
!insertmacro: end of _If
Push: "$INSTDIR\pythonw.exe" -E -s "$INSTDIR\Lib\_nsis.py" pre_uninstall
!insertmacro: _Else
!insertmacro: end of _Else
Push: "$INSTDIR\python.exe" -E -s "$INSTDIR\Lib\_nsis.py" pre_uninstall
!insertmacro: _EndIf
!insertmacro: end of _EndIf
Push: Failed to run pre_uninstall

@dokempf
Copy link
Member Author

dokempf commented May 16, 2024

It turns out that this is only happens, when the uninstallation is triggered from the Apps settings, not if the uninstaller exe is run directly.

@dokempf
Copy link
Member Author

dokempf commented May 16, 2024

Also, Hannah reports that this is working fine on Windows 10 (Sample Size 1 though).

@dokempf
Copy link
Member Author

dokempf commented May 16, 2024

Reported this upstream: conda/constructor#799

@dokempf
Copy link
Member Author

dokempf commented Oct 10, 2024

Somehow, this seems to be unreproducible outside my Windows laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant